File percona-toolkit-2.2.x-disable-default-version-c... of Package percona-toolkit

Overview Repositories Revisions Requests Users Attributes Meta

File percona-toolkit-2.2.x-disable-default-version-check.patch of Package percona-toolkit (Revision dffb4c30bf9f6e43a0468f7f0951a47c)

Currently displaying revision dffb4c30bf9f6e43a0468f7f0951a47c , Show latest

From: Andreas Stieger <andreas.stieger@gmx.de>
Date: Mon, 17 Feb 2014 00:15:35 +0000
Subject: disable automatic version check for all tools
References: https://bugzilla.novell.com/show_bug.cgi?id=864194 https://bugs.launchpad.net/percona-toolkit/+bug/1279502
Upstream: no

Prevents transmission of version information to an external host
in the default configuration.
Can be used by owner of a Percona Server (or an attacker who can
control this destination for the client) to collect arbitrary
MySQL configuration parameters and execute commands (with -v).
Now the version check needs to be requested via command line or
global/tool specific/user configuration. (--version-check)

Note that the doc is parsed into a Perl Getopt::Long spec at runtime.
Setting "default: no" does not work, "default: 0" would work.
The spec file contains a %check section that tests this.
Patching the source was chosen over supplying default configuration
files in /etc/percona-toolkit/percona-toolkit.conf because not all
tools actually support the version check and would throw warnings.

Index: percona-toolkit-2.2.18/bin/pt-archiver
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-archiver
+++ percona-toolkit-2.2.18/bin/pt-archiver
@@ -7959,8 +7959,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-config-diff
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-config-diff
+++ percona-toolkit-2.2.18/bin/pt-config-diff
@@ -5640,8 +5640,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-deadlock-logger
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-deadlock-logger
+++ percona-toolkit-2.2.18/bin/pt-deadlock-logger
@@ -5426,8 +5426,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-diskstats
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-diskstats
+++ percona-toolkit-2.2.18/bin/pt-diskstats
@@ -5502,8 +5502,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-duplicate-key-checker
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-duplicate-key-checker
+++ percona-toolkit-2.2.18/bin/pt-duplicate-key-checker
@@ -5484,8 +5484,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-find
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-find
+++ percona-toolkit-2.2.18/bin/pt-find
@@ -4478,8 +4478,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-fk-error-logger
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-fk-error-logger
+++ percona-toolkit-2.2.18/bin/pt-fk-error-logger
@@ -4413,8 +4413,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-heartbeat
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-heartbeat
+++ percona-toolkit-2.2.18/bin/pt-heartbeat
@@ -6962,8 +6962,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-index-usage
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-index-usage
+++ percona-toolkit-2.2.18/bin/pt-index-usage
@@ -7414,8 +7414,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-kill
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-kill
+++ percona-toolkit-2.2.18/bin/pt-kill
@@ -7758,8 +7758,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-online-schema-change
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-online-schema-change
+++ percona-toolkit-2.2.18/bin/pt-online-schema-change
@@ -11866,8 +11866,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-query-digest
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-query-digest
+++ percona-toolkit-2.2.18/bin/pt-query-digest
@@ -16353,8 +16353,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-slave-delay
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-slave-delay
+++ percona-toolkit-2.2.18/bin/pt-slave-delay
@@ -4733,8 +4733,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-slave-restart
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-slave-restart
+++ percona-toolkit-2.2.18/bin/pt-slave-restart
@@ -5805,8 +5805,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-table-checksum
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-table-checksum
+++ percona-toolkit-2.2.18/bin/pt-table-checksum
@@ -12683,8 +12683,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-table-sync
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-table-sync
+++ percona-toolkit-2.2.18/bin/pt-table-sync
@@ -12566,8 +12566,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-upgrade
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-upgrade
+++ percona-toolkit-2.2.18/bin/pt-upgrade
@@ -11122,8 +11122,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.18/bin/pt-variable-advisor
===================================================================
--- percona-toolkit-2.2.18.orig/bin/pt-variable-advisor
+++ percona-toolkit-2.2.18/bin/pt-variable-advisor
@@ -6003,8 +6003,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two

Places

File percona-toolkit-2.2.x-disable-default-version-check.patch of Package percona-toolkit (Revision dffb4c30bf9f6e43a0468f7f0951a47c)

Places