File audacity-misc-errors.patch of Package audacity

Overview Repositories Revisions Requests Users Attributes Meta

File audacity-misc-errors.patch of Package audacity (Revision 0e353f908154eeddd1b24aa128c976dd)

Currently displaying revision 0e353f908154eeddd1b24aa128c976dd , Show latest

From: Dave Plater <plater@opensuse.org>
Date: Thu 22 Feb 12:11:43 SAST 2018
Subject: Fix various build errors found by rpmlint
References:
Upstream: reported to audacity devel list.

I: Program is using implicit definitions of functions getting
    pointers or implemented by macros. These functions need to use their
    correct prototypes to allow correct argument passing on e.g. x86_64 .
      - Implicit memory/string functions need #include <string.h>.
      - Implicit *printf functions need #include <stdio.h>.
      - Implicit *printf functions need #include <stdio.h>.
      - Implicit *read* functions need #include <unistd.h>.
      - Implicit *recv* functions need #include <sys/socket.h>.
W: audacity implicit-pointer-decl pm_linux/finddefault.c:16
 
I: Program is using uninitialized variables.
    Note the difference between "is used" and "may be used"
W: audacity uninitialized-variable ../include/audacity/EffectAutomationParameters.h:122
W: audacity uninitialized-variable sse.h:19
 
I: Program uses operation a <= b <= c, which is not well defined.
E: audacity mathmeaning SplashDialog.cpp:148

Index: lib-src/portmidi/pm_linux/finddefault.c
===================================================================
--- lib-src/portmidi/pm_linux/finddefault.c.orig	2018-02-14 09:11:20.000000000 +0200
+++ lib-src/portmidi/pm_linux/finddefault.c	2018-02-22 13:22:36.862525944 +0200
@@ -5,6 +5,8 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
+#include <unistd.h>
+#include <sys/socket.h>
 #include "portmidi.h"
 
 #define STRING_MAX 256
Index: src/SplashDialog.cpp
===================================================================
--- src/SplashDialog.cpp.orig	2018-02-14 09:11:20.000000000 +0200
+++ src/SplashDialog.cpp	2018-02-22 13:22:36.870526246 +0200
@@ -114,7 +114,9 @@ void SplashDialog::Populate( ShuttleGui
    S.Prop(0).AddWindow( icon );
 
    icon
-#if  ((((AUDACITY_VERSION % 10) ^ 1) >> 1) == 1)
+/* #if  ((((AUDACITY_VERSION % 10) ^ 1) >> 1) == 1) */
+#if 1 == 0
+
    ->Bind(wxEVT_LEFT_DOWN
 
                                     ,[this](
Index: include/audacity/EffectAutomationParameters.h
===================================================================
--- include/audacity/EffectAutomationParameters.h.orig	2018-02-14 09:11:20.000000000 +0200
+++ include/audacity/EffectAutomationParameters.h	2018-02-22 13:32:46.233388822 +0200
@@ -119,7 +119,7 @@ public:
 
    bool ReadFloat(const wxString & key, float *pf) const
    {
-      double d = *pf;
+      double d = (float) *pf;
       bool success = Read(key, &d);
       if (success)
       {

Places

File audacity-misc-errors.patch of Package audacity (Revision 0e353f908154eeddd1b24aa128c976dd)

Places