File audacity-no_return_in_nonvoid.patch of Package audacity

Overview Repositories Revisions Requests Users Attributes Meta

File audacity-no_return_in_nonvoid.patch of Package audacity (Revision 114b1ad00ccf4bd121cb80ef176877c1)

Currently displaying revision 114b1ad00ccf4bd121cb80ef176877c1 , Show latest

diff --git a/lib-src/libnyquist/nyquist/cmupv/src/cmupv.c b/lib-src/libnyquist/nyquist/cmupv/src/cmupv.c
index 8c1c7b5..e05c28d 100644
--- a/lib-src/libnyquist/nyquist/cmupv/src/cmupv.c
+++ b/lib-src/libnyquist/nyquist/cmupv/src/cmupv.c
@@ -600,6 +600,7 @@ double pv_get_effective_pos(Phase_vocoder x)
         return -(pv->ratio * pv->fftsize / 2.0);
     } // I can't think of any other case.
     assert(FALSE);
+    return(0);
 }
 
 
diff --git a/lib-src/libnyquist/nyquist/xlisp/xlbfun.c b/lib-src/libnyquist/nyquist/xlisp/xlbfun.c
index 37ab604..f434a67 100644
--- a/lib-src/libnyquist/nyquist/xlisp/xlbfun.c
+++ b/lib-src/libnyquist/nyquist/xlisp/xlbfun.c
@@ -603,7 +603,10 @@ LVAL xcleanup(void)
 {
     xllastarg();
     xlcleanup();
-    /* compiler might (wrongly) complain there is no return value */
+    /* this point will never be reached because xlcleanup() does a
+    longjmp(). The return is added to avoid false positive
+    error messages from static analyzers and compilers */
+    return (NIL);
 }
 
 /* xtoplevel - special form 'top-level' */
diff --git a/lib-src/portsmf/allegro.cpp b/lib-src/portsmf/allegro.cpp
index a87117e..d471785 100644
--- a/lib-src/portsmf/allegro.cpp
+++ b/lib-src/portsmf/allegro.cpp
@@ -2905,6 +2905,9 @@ Alg_event_ptr &Alg_seq::operator[](int i)
         tr++;
     }
     assert(false); // out of bounds
+    Alg_event_ptr ab_track;
+    return ab_track; // Fix false positive error: control reaches end of non-void function [-Werror=return-type]
+    // Ignores the assert A gcc bug?
 }
 #pragma warning(default: 4715)
 
diff --git a/src/widgets/NumericTextCtrl.cpp b/src/widgets/NumericTextCtrl.cpp
index 9bd57e2..0e46c96 100644
--- a/src/widgets/NumericTextCtrl.cpp
+++ b/src/widgets/NumericTextCtrl.cpp
@@ -679,6 +679,7 @@ static const BuiltinFormatString BandwidthConverterFormats_[] = {
          case NumericConverter::BANDWIDTH:
             return WXSIZEOF(BandwidthConverterFormats_);
       }
+      return WXSIZEOF(BandwidthConverterFormats_);
    }
 }

Places

File audacity-no_return_in_nonvoid.patch of Package audacity (Revision 114b1ad00ccf4bd121cb80ef176877c1)

Places