File electron29-nan-SetAccessor.patch of Package code

Overview Repositories Revisions Requests Users Attributes Meta

File electron29-nan-SetAccessor.patch of Package code

From 1b630ddb3412cde35b64513662b440f9fd71e1ff Mon Sep 17 00:00:00 2001
From: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
Date: Tue, 27 Feb 2024 05:01:13 -0800
Subject: [PATCH] Fix builds for Electron 29 (#966)

`ObjectTemplate::SetAccessor` signature has changed in the V8 >= 12, and
no longer accepts `v8::AccessControl` parameter. The `v8::AccessControl`
enum is in fact a single value now so no public users of nan would be
broken if we just stop passing it down to V8.
---
 nan.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/nan.h b/nan.h
index 2a683494..9c75907f 100644
--- a/build/node_modules/tree-sitter/node_modules/nan/nan.h
+++ b/build/node_modules/tree-sitter/node_modules/nan/nan.h
@@ -2550,7 +2550,9 @@ NAN_DEPRECATED inline void SetAccessor(
     , getter_
     , setter_
     , obj
+#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 || V8_MAJOR_VERSION == 12 && V8_MINOR_VERSION < 2
     , settings
+#endif
     , attribute
 #if (NODE_MODULE_VERSION < NODE_16_0_MODULE_VERSION)
     , signature
@@ -2596,7 +2598,9 @@ inline void SetAccessor(
     , getter_
     , setter_
     , obj
+#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 || V8_MAJOR_VERSION == 12 && V8_MINOR_VERSION < 2
     , settings
+#endif
     , attribute
   );
 }
diff --git a/nan.h b/nan.h
index 2a683494..9c75907f 100644
--- a/build/node_modules/nan/nan.h
+++ b/build/node_modules/nan/nan.h
@@ -2550,7 +2550,9 @@ NAN_DEPRECATED inline void SetAccessor(
     , getter_
     , setter_
     , obj
+#if !defined(V8_MAJOR_VERSION) || V8_MAJOR_VERSION < 12 || V8_MAJOR_VERSION == 12 && V8_MINOR_VERSION < 2
     , settings
+#endif
     , attribute
   );
 }

Places

File electron29-nan-SetAccessor.patch of Package code

Places