File 2461-Set-buffer-sizes-according-to-fixed-gen_tc... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 2461-Set-buffer-sizes-according-to-fixed-gen_tcp_socket-i.patch of Package erlang

From 198cc4d1fe0e0eb0cd6251b5bc9e7518731721f0 Mon Sep 17 00:00:00 2001
From: Raimo Niskanen <raimo@erlang.org>
Date: Fri, 26 Jan 2024 16:05:16 +0100
Subject: [PATCH 11/14] Set buffer sizes according to fixed gen_tcp_socket
 implementation

---
 lib/kernel/test/gen_tcp_socket_SUITE.erl | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/lib/kernel/test/gen_tcp_socket_SUITE.erl b/lib/kernel/test/gen_tcp_socket_SUITE.erl
index 5384f3b103..8a7cadb18c 100644
--- a/lib/kernel/test/gen_tcp_socket_SUITE.erl
+++ b/lib/kernel/test/gen_tcp_socket_SUITE.erl
@@ -34,8 +34,8 @@ groups() ->
      %%
      {dev,          [{group,dev_direct},
                      {group,dev_inet}, {group,dev_socket}]},
-     {dev_inet,     [active_raw, active_false, active_once]},
-     {dev_socket,   [active_raw, active_false, active_once]},
+     {dev_inet,     [active_raw, active_true, active_false, active_once]},
+     {dev_socket,   [active_raw, active_true, active_false, active_once]},
      {dev_direct,   testcases(direct)},
      %%
      {small,        backend_groups()},
@@ -81,7 +81,7 @@ init_per_group(Nm, Config) ->
         smoketest   -> [{burden,0} | Config];
         benchmark   -> [{burden,2} | Config];
         %%
-        dev         -> init_per_group(huge, [{burden,2} | Config]);
+        dev         -> init_per_group(small, [{burden,3} | Config]);
         dev_inet    -> [{backend,inet}   | Config];
         dev_socket  -> [{backend,socket} | Config];
         dev_direct  -> [{backend,direct} | Config];
@@ -250,9 +250,8 @@ run_xfer(
 
 connect(direct, Sockaddr, _) ->
     {ok, S} = socket:open(?DOMAIN, stream),
-    ok = socket:setopt(S, {socket,sndbuf}, ?BUFSIZE),
     ok = socket:setopt(S, {socket,rcvbuf}, ?BUFSIZE),
-    ok = socket:setopt(S, {otp,rcvbuf},    ?BUFSIZE bsl 1),
+    ok = socket:setopt(S, {otp,rcvbuf},    ?BUFSIZE),
     io:format("socket:connect [~p].~n", [Sockaddr]),
     case socket:connect(S, Sockaddr) of
         ok ->
@@ -263,15 +262,13 @@ connect(direct, Sockaddr, _) ->
 connect(Backend, Sockaddr, active_raw) -> % {active,true}, {packet,raw}
     Opts =
         [{inet_backend,Backend}, binary, {active,true},
-         ?DOMAIN,
-         {sndbuf,?BUFSIZE}, {recbuf,?BUFSIZE}, {buffer, ?BUFSIZE}],
+         ?DOMAIN, {recbuf,?BUFSIZE}],
     io:format("gen_tcp:connect(~p, ~p).~n", [Sockaddr, Opts]),
     gen_tcp:connect(Sockaddr, Opts);
 connect(Backend, Sockaddr, TC) ->
     Opts =
         [{inet_backend,Backend}, binary, {active,tc2active(TC)}, {packet,4},
-         ?DOMAIN,
-         {sndbuf,?BUFSIZE}, {recbuf,?BUFSIZE}, {buffer, ?BUFSIZE}],
+         ?DOMAIN, {recbuf,?BUFSIZE}],
     io:format("gen_tcp:connect(~p, ~p).~n", [Sockaddr, Opts]),
     gen_tcp:connect(Sockaddr, Opts).
 
-- 
2.35.3

Places

File 2461-Set-buffer-sizes-according-to-fixed-gen_tcp_socket-i.patch of Package erlang

Places