File 1911-Optimize-compile-time-for-is_record-3-with... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1911-Optimize-compile-time-for-is_record-3-with-huge-size.patch of Package erlang (Revision 2f15b05a39d64e5cba90e927e8665465)

Currently displaying revision 2f15b05a39d64e5cba90e927e8665465 , Show latest

From 08f30404ee23b81b6c9182c63977c3e562f231dc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Sun, 28 May 2023 07:37:37 +0200
Subject: [PATCH] Optimize compile time for is_record/3 with huge size

With the fix in #7319 merged to the master branch, the following
function would take about half a minute to compile on my computer:

test(Rec) when is_record(Rec, a, 10_000_000) -> Rec.
---
 lib/compiler/src/beam_core_to_ssa.erl | 42 ++++++++++++++-------------
 1 file changed, 22 insertions(+), 20 deletions(-)

diff --git a/lib/compiler/src/beam_core_to_ssa.erl b/lib/compiler/src/beam_core_to_ssa.erl
index bde071b4d6..0aea7210bc 100644
--- a/lib/compiler/src/beam_core_to_ssa.erl
+++ b/lib/compiler/src/beam_core_to_ssa.erl
@@ -375,15 +375,8 @@ expr(#c_call{anno=A,module=M0,name=F0,args=Cargs}, Sub, St0) ->
             Remote = #b_remote{mod=M,name=F,arity=length(Args)},
             {#cg_call{anno=A,op=Remote,args=Args},Ap,St};
         is_record ->
-            [TupleVar,#c_literal{}=Tag,#c_literal{val=Arity}] = Cargs,
-            {[Any|NotUsed],St} = new_core_vars(Arity, St0),
-            TuplePat = #c_tuple{es=[Tag|NotUsed]},
-            False = #c_literal{val=false},
-            True = #c_literal{val=true},
-            Cs = [#c_clause{pats=[TuplePat],guard=True,body=True},
-                  #c_clause{pats=[Any],guard=True,body=False}],
-            Case = #c_case{arg=TupleVar,clauses=Cs},
-            expr(Case, Sub, St);
+            {Args,Ap,St} = atomic_list(Cargs, Sub, St0),
+            {#cg_internal{anno=internal_anno(A),op=is_record,args=Args},Ap,St};
         error ->
             %% Invalid call (e.g. M:42/3). Issue a warning, and let
             %% the generated code call apply/3.
@@ -1020,16 +1013,6 @@ new_vars(0, St, Vs) -> {Vs,St}.
 
 make_vars(Vs) -> [#b_var{name=V} || V <- Vs].
 
-%% new_core_vars(Count, State) -> {[#c_var{}],State}.
-
-new_core_vars(N, St) when is_integer(N) ->
-    new_core_vars(N, St, []).
-
-new_core_vars(N, St0, Vs) when N > 0 ->
-    {V,St1} = new_var_name(St0),
-    new_core_vars(N-1, St1, [#c_var{name=V}|Vs]);
-new_core_vars(0, St, Vs) -> {Vs,St}.
-
 %% call_type(Mod, Name, [Arg], State) -> bif | call | is_record | error.
 
 call_type(#c_literal{val=M}, #c_literal{val=F}, As, St) when is_atom(M), is_atom(F) ->
@@ -2402,7 +2385,8 @@ cg(#cg_seq{arg=Arg,body=Body}, St0) ->
     {ArgIs ++ BodyIs,St};
 cg(#cg_call{anno=Anno,op=Func,args=As,ret=Rs}, St) ->
     call_cg(Func, As, Rs, Anno, St);
-cg(#cg_internal{anno=Anno,op=Op,args=As,ret=Rs}, St) ->
+cg(#cg_internal{anno=Anno,op=Op,args=As0,ret=Rs}, St) ->
+    As = ssa_args(As0, St),
     internal_cg(Anno, Op, As, Rs, St);
 cg(#cg_try{arg=Ta,vars=Vs,body=Tb,evars=Evs,handler=Th,ret=Rs}, St) ->
     try_cg(Ta, Vs, Tb, Evs, Th, Rs, St);
@@ -2843,6 +2827,24 @@ internal_anno(Le) ->
 
 %% internal_cg(Anno, Op, [Arg], [Ret], State) ->
 %%      {[Ainstr],State}.
+internal_cg(_Anno, is_record, [Tuple,TagVal,ArityVal], [Dst], St0) ->
+    {Arity,St1} = new_ssa_var(St0),
+    {Tag,St2} = new_ssa_var(St1),
+    {Phi,St3} = new_label(St2),
+    {False,St4} = new_label(St3),
+    {Is0,St5} = make_cond_branch({bif,is_tuple}, [Tuple], False, St4),
+    GetArity = #b_set{op={bif,tuple_size},dst=Arity,args=[Tuple]},
+    {Is1,St6} = make_cond_branch({bif,'=:='}, [Arity,ArityVal], False, St5),
+    GetTag = #b_set{op=get_tuple_element,dst=Tag,
+                    args=[Tuple,#b_literal{val=0}]},
+    {Is2,St} = make_cond_branch({bif,'=:='}, [Tag,TagVal], False, St6),
+    Is3 = [#cg_break{args=[#b_literal{val=true}],phi=Phi},
+           {label,False},
+           #cg_break{args=[#b_literal{val=false}],phi=Phi},
+           {label,Phi},
+           #cg_phi{vars=[Dst]}],
+    Is = Is0 ++ [GetArity] ++ Is1 ++ [GetTag] ++ Is2 ++ Is3,
+    {Is,St};
 internal_cg(Anno, recv_peek_message, [], [#b_var{name=Succeeded0},
                                           #b_var{}=Dst], St0) ->
     St = new_succeeded_value(Succeeded0, Dst, St0),
-- 
2.35.3

Places

File 1911-Optimize-compile-time-for-is_record-3-with-huge-size.patch of Package erlang (Revision 2f15b05a39d64e5cba90e927e8665465)

Places