File 1511-public_key-adjust-ocsp_extensions-1-for-in... of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 1511-public_key-adjust-ocsp_extensions-1-for-interoperabi.patch of Package erlang

From 34bebe0cd42c69b58cc09d7ffce0def46d5393a1 Mon Sep 17 00:00:00 2001
From: Jakub Witczak <kuba@erlang.org>
Date: Fri, 5 Apr 2024 20:27:04 +0200
Subject: [PATCH 1/5] public_key: adjust ocsp_extensions/1 for interoperability

- don't include get_acceptable_response_types_extn
- ClientHello StatusRequest will have empty extensions unless
  OCSP nonce is requested
- see GH-8242
---
 lib/public_key/src/public_key.erl        | 3 +--
 lib/public_key/test/public_key_SUITE.erl | 6 +-----
 2 files changed, 2 insertions(+), 7 deletions(-)

diff --git a/lib/public_key/src/public_key.erl b/lib/public_key/src/public_key.erl
index 39ab082dc3..98192f2f55 100644
--- a/lib/public_key/src/public_key.erl
+++ b/lib/public_key/src/public_key.erl
@@ -2003,8 +2003,7 @@ pkix_ocsp_validate(Cert, IssuerCert, OcspRespDer, NonceExt, Options)
 %% Description: Get OCSP stapling extensions for request
 %%--------------------------------------------------------------------
 ocsp_extensions(Nonce) ->
-    [Extn || Extn <- [pubkey_ocsp:get_nonce_extn(Nonce),
-                      pubkey_ocsp:get_acceptable_response_types_extn()],
+    [Extn || Extn <- [pubkey_ocsp:get_nonce_extn(Nonce)],
              erlang:is_record(Extn, 'Extension')].
 
 %%--------------------------------------------------------------------
diff --git a/lib/public_key/test/public_key_SUITE.erl b/lib/public_key/test/public_key_SUITE.erl
index d8e66c9f0a..ed7d8e3fa2 100644
--- a/lib/public_key/test/public_key_SUITE.erl
+++ b/lib/public_key/test/public_key_SUITE.erl
@@ -1490,11 +1490,7 @@ ocsp_extensions(_Config) ->
         [{'Extension',
           ?'id-pkix-ocsp-nonce',
           asn1_DEFAULT,
-          <<4,8,66,243,220,236,16,118,51,215>>},
-         {'Extension',
-          ?'id-pkix-ocsp-response',
-          asn1_DEFAULT,
-          <<48,11,6,9,43,6,1,5,5,7,48,1,1>>}],
+          <<4,8,66,243,220,236,16,118,51,215>>}],
     ExpectedExtentions = public_key:ocsp_extensions(Nonce).
 
 pkix_ocsp_validate() ->
-- 
2.35.3

Places

File 1511-public_key-adjust-ocsp_extensions-1-for-interoperabi.patch of Package erlang

Places