File 0347-erts-Modernize-K-R-style-functions.patch of Package erlang

Overview Repositories Revisions Requests Users Attributes Meta

File 0347-erts-Modernize-K-R-style-functions.patch of Package erlang (Revision db1acd30fa2136b2cf32ed954074cb8e)

Currently displaying revision db1acd30fa2136b2cf32ed954074cb8e , Show latest

From 2269b39d88b6826c5f59a66db1b5dde1cd2abd11 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Gustavsson?= <bjorn@erlang.org>
Date: Sun, 11 Jun 2023 07:00:19 +0200
Subject: [PATCH 1/3] erts: Modernize K&R-style functions

Modern versions of Clang warn about functions using K&R syntax.
---
 erts/emulator/beam/code_ix.c                | 6 +++---
 erts/lib_src/yielding_c_fun/ycf_yield_fun.c | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/erts/emulator/beam/code_ix.c b/erts/emulator/beam/code_ix.c
index 3888c72363..d9fd133707 100644
--- a/erts/emulator/beam/code_ix.c
+++ b/erts/emulator/beam/code_ix.c
@@ -349,15 +349,15 @@ static int has_code_permission(struct code_permission *perm)
     return 0;
 }
 
-int erts_has_code_load_permission() {
+int erts_has_code_load_permission(void) {
     return erts_has_code_stage_permission() && erts_has_code_mod_permission();
 }
 
-int erts_has_code_stage_permission() {
+int erts_has_code_stage_permission(void) {
     return has_code_permission(&code_stage_permission);
 }
 
-int erts_has_code_mod_permission() {
+int erts_has_code_mod_permission(void) {
     return has_code_permission(&code_mod_permission);
 }
 #endif
diff --git a/erts/lib_src/yielding_c_fun/ycf_yield_fun.c b/erts/lib_src/yielding_c_fun/ycf_yield_fun.c
index cd927b7716..bc8dccd56a 100644
--- a/erts/lib_src/yielding_c_fun/ycf_yield_fun.c
+++ b/erts/lib_src/yielding_c_fun/ycf_yield_fun.c
@@ -140,7 +140,7 @@ ycf_node* mk_print_offsets_for_struct_fields(char* ycf_trap_state_name,
     }
     char* ret =
         ycf_string_new(("static void %s_print_offsets_for_struct_fields(void);\n"
-                        "static void %s_print_offsets_for_struct_fields() {\n"
+                        "static void %s_print_offsets_for_struct_fields(void) {\n"
                         "fprintf(stderr, \"Field offsets for struct %s:\\n\");\n"
                         "%s\n"
                         "}\n"),
@@ -906,13 +906,13 @@ void ast_add_yield_code_generated_define(ycf_node* source_out_tree/*Will be chan
      "#include <inttypes.h>\n"
      "static void* ycf_find_stack_bottom_conservative_helper(void);\n"
      "static void* ycf_find_stack_bottom_conservative(void);\n"
-     "static void* ycf_find_stack_bottom_conservative_helper() {\n"
+     "static void* ycf_find_stack_bottom_conservative_helper(void) {\n"
      "  void* p = NULL;\n"
      "  volatile intptr_t tmp = (intptr_t)&p;\n"
      "  /* codechecker_intentional [StackAddrEscapeBase] */\n"
      "  return (void*)tmp;\n"
      "}\n"
-     "static void* ycf_find_stack_bottom_conservative() {\n"
+     "static void* ycf_find_stack_bottom_conservative(void) {\n"
      "  jmp_buf env;\n"
      "  setjmp(env);\n"
      "\n"
-- 
2.35.3

Places

File 0347-erts-Modernize-K-R-style-functions.patch of Package erlang (Revision db1acd30fa2136b2cf32ed954074cb8e)

Places