File 0008-This-commit-fixes-a-bug-seen-when-using-th... of Package rubygem-acts-as-taggable-on

Overview Repositories Revisions Requests Users Attributes Meta

File 0008-This-commit-fixes-a-bug-seen-when-using-the-tagged_w.patch of Package rubygem-acts-as-taggable-on

From fae4236357a93b206a289fd501b87cdfdb3bf5f7 Mon Sep 17 00:00:00 2001
From: Joe Goggins <goggins@umn.edu>
Date: Thu, 17 Jun 2010 05:13:19 +0800
Subject: [PATCH 8/9] This commit fixes a bug seen when using the tagged_with("something") method.

I have an ActiveRecord class defined like such:

class Athlete < ActiveRecord::Base
		set_table_name "warehouse.ps_person"
		acts_as_taggable_on :tags
	end

Athlete.tagged_with("something") creates sql like this:

SELECT `warehouse`.`ps_person`.* FROM `warehouse`.`ps_person`
	JOIN taggings warehouse.ps_person_taggings_something_932  ON warehouse.ps_person_taggings_something_932.taggable_id = warehouse.ps_person.emplid AND warehouse.ps_person_taggings_something_932.taggable_type = 'Athlete' AND warehouse.ps_person_taggings_something_932.tag_id = 2

This fix simply uses the undecorated_table_name instead of the table_name to define the basename of the alias
---
 .../acts_as_taggable_on/core.rb                    |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/acts_as_taggable_on/acts_as_taggable_on/core.rb b/lib/acts_as_taggable_on/acts_as_taggable_on/core.rb
index 46d22bb..98b42b2 100644
--- a/lib/acts_as_taggable_on/acts_as_taggable_on/core.rb
+++ b/lib/acts_as_taggable_on/acts_as_taggable_on/core.rb
@@ -91,7 +91,7 @@ module ActsAsTaggableOn::Taggable
             safe_tag = tag.name.gsub(/[^a-zA-Z0-9]/, '')
             prefix   = "#{safe_tag}_#{rand(1024)}"
 
-            taggings_alias = "#{table_name}_taggings_#{prefix}"
+            taggings_alias = "#{undecorated_table_name}_taggings_#{prefix}"
 
             tagging_join  = "JOIN #{ActsAsTaggableOn::Tagging.table_name} #{taggings_alias}" +
                             "  ON #{taggings_alias}.taggable_id = #{table_name}.#{primary_key}" +
@@ -103,7 +103,7 @@ module ActsAsTaggableOn::Taggable
           end
         end
 
-        taggings_alias, tags_alias = "#{table_name}_taggings_group", "#{table_name}_tags_group"
+        taggings_alias, tags_alias = "#{undecorated_table_name}_taggings_group", "#{undecorated_table_name}_tags_group"
 
         if options.delete(:match_all)
           joins << "LEFT OUTER JOIN #{ActsAsTaggableOn::Tagging.table_name} #{taggings_alias}" +
-- 
1.7.1

Places

File 0008-This-commit-fixes-a-bug-seen-when-using-the-tagged_w.patch of Package rubygem-acts-as-taggable-on

Places