File percona-toolkit-2.2.x-disable-default-version-c... of Package percona-toolkit

Overview Repositories Revisions Requests Users Attributes Meta

File percona-toolkit-2.2.x-disable-default-version-check.patch of Package percona-toolkit (Revision 20b0bdcd34301e0952827b4066f29002)

Currently displaying revision 20b0bdcd34301e0952827b4066f29002 , Show latest

From: Andreas Stieger <andreas.stieger@gmx.de>
Date: Mon, 17 Feb 2014 00:15:35 +0000
Subject: disable automatic version check for all tools
References: https://bugzilla.novell.com/show_bug.cgi?id=864194 https://bugs.launchpad.net/percona-toolkit/+bug/1279502
Upstream: no

Prevents transmission of version information to an external host
in the default configuration.
Can be used by owner of a Percona Server (or an attacker who can
control this destination for the client) to collect arbitrary
MySQL configuration parameters and execute commands (with -v).
Now the version check needs to be requested via command line or
global/tool specific/user configuration. (--version-check)

Note that the doc is parsed into a Perl Getopt::Long spec at runtime.
Setting "default: no" does not work, "default: 0" would work.
The spec file contains a %check section that tests this.
Patching the source was chosen over supplying default configuration
files in /etc/percona-toolkit/percona-toolkit.conf because not all
tools actually support the version check and would throw warnings.

Index: percona-toolkit-2.2.14/bin/pt-archiver
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-archiver	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-archiver	2015-04-14 21:58:15.000000000 +0200
@@ -7483,8 +7483,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-config-diff
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-config-diff	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-config-diff	2015-04-14 21:58:15.000000000 +0200
@@ -5613,8 +5613,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-deadlock-logger
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-deadlock-logger	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-deadlock-logger	2015-04-14 21:58:15.000000000 +0200
@@ -5398,8 +5398,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-diskstats
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-diskstats	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-diskstats	2015-04-14 21:58:15.000000000 +0200
@@ -5475,8 +5475,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-duplicate-key-checker
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-duplicate-key-checker	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-duplicate-key-checker	2015-04-14 21:58:15.000000000 +0200
@@ -5450,8 +5450,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-find
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-find	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-find	2015-04-14 21:58:15.000000000 +0200
@@ -4447,8 +4447,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-fk-error-logger
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-fk-error-logger	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-fk-error-logger	2015-04-14 21:58:15.000000000 +0200
@@ -4385,8 +4385,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-heartbeat
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-heartbeat	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-heartbeat	2015-04-14 21:58:15.000000000 +0200
@@ -6058,8 +6058,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-index-usage
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-index-usage	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-index-usage	2015-04-14 21:58:15.000000000 +0200
@@ -7384,8 +7384,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-kill
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-kill	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-kill	2015-04-14 21:58:15.000000000 +0200
@@ -7711,8 +7711,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-online-schema-change
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-online-schema-change	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-online-schema-change	2015-04-14 21:58:15.000000000 +0200
@@ -11586,8 +11586,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-query-digest
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-query-digest	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-query-digest	2015-04-14 21:58:15.000000000 +0200
@@ -16308,8 +16308,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-slave-delay
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-slave-delay	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-slave-delay	2015-04-14 21:58:15.000000000 +0200
@@ -4705,8 +4705,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-slave-restart
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-slave-restart	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-slave-restart	2015-04-14 21:58:15.000000000 +0200
@@ -5771,8 +5771,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-table-checksum
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-table-checksum	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-table-checksum	2015-04-14 21:58:15.000000000 +0200
@@ -12534,8 +12534,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-table-sync
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-table-sync	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-table-sync	2015-04-14 21:58:15.000000000 +0200
@@ -12521,8 +12521,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-upgrade
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-upgrade	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-upgrade	2015-04-14 21:58:15.000000000 +0200
@@ -11096,8 +11096,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two
Index: percona-toolkit-2.2.14/bin/pt-variable-advisor
===================================================================
--- percona-toolkit-2.2.14.orig/bin/pt-variable-advisor	2015-04-10 11:12:11.000000000 +0200
+++ percona-toolkit-2.2.14/bin/pt-variable-advisor	2015-04-14 21:58:15.000000000 +0200
@@ -5975,8 +5975,6 @@ Show version and exit.
 
 =item --[no]version-check
 
-default: yes
-
 Check for the latest version of Percona Toolkit, MySQL, and other programs.
 
 This is a standard "check for updates automatically" feature, with two

Places

File percona-toolkit-2.2.x-disable-default-version-check.patch of Package percona-toolkit (Revision 20b0bdcd34301e0952827b4066f29002)

Places