File 0001-Fix-build-with-Python-3.8-and-no-undefined... of Package libArcus

Overview Repositories Revisions Requests Users Attributes Meta

File 0001-Fix-build-with-Python-3.8-and-no-undefined-linker-flags.patch of Package libArcus (Revision 76d2f17cb845bc0e7029c7cc37649501)

Currently displaying revision 76d2f17cb845bc0e7029c7cc37649501 , Show latest

From 53959415a4748a3518a6586fab6b8f821bb121c3 Mon Sep 17 00:00:00 2001
From: StefanBruens <stefan.bruens@rwth-aachen.de>
Date: Sun, 25 Oct 2020 06:23:16 +0100
Subject: [PATCH] Fix build with Python 3.8 and --no-undefined linker flags

Currently the build uses the CMAKE_SHARED_LINKER_FLAGS for both
the libArcus shared library as well as the Python module. Starting with
Python 3.8 the Python module is no longer linked to libpython, and thus
some symbols stay undefined.

The correct build type for python modules is "MODULE", which uses the
distinct CMAKE_MODULE_LINKER_FLAGS. This allows to keep the
'-Wl,--no-undefined' linker flag for libArcus.

https://github.com/Ultimaker/libArcus/pull/109
---
 cmake/SIPMacros.cmake | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/cmake/SIPMacros.cmake b/cmake/SIPMacros.cmake
index e80198f..50553e0 100644
--- a/cmake/SIPMacros.cmake
+++ b/cmake/SIPMacros.cmake
@@ -105,12 +105,7 @@ MACRO(ADD_SIP_PYTHON_MODULE MODULE_NAME MODULE_SIP)
         COMMAND ${SIP_EXECUTABLE} ${_sip_tags} ${_sip_x} ${SIP_EXTRA_OPTIONS} -j ${SIP_CONCAT_PARTS} -c ${CMAKE_CURRENT_BINARY_DIR}/${_module_path} ${_sip_includes} ${_abs_module_sip}
         DEPENDS ${_abs_module_sip} ${SIP_EXTRA_FILES_DEPEND}
     )
-    # not sure if type MODULE could be uses anywhere, limit to cygwin for now
-    IF (CYGWIN OR APPLE)
-        ADD_LIBRARY(${_logical_name} MODULE ${_sip_output_files} ${SIP_EXTRA_SOURCE_FILES})
-    ELSE (CYGWIN OR APPLE)
-        ADD_LIBRARY(${_logical_name} SHARED ${_sip_output_files} ${SIP_EXTRA_SOURCE_FILES})
-    ENDIF (CYGWIN OR APPLE)
+    ADD_LIBRARY(${_logical_name} MODULE ${_sip_output_files} ${SIP_EXTRA_SOURCE_FILES})
     IF (NOT APPLE)
         IF ("${Python3_VERSION_MINOR}" GREATER 7)
             MESSAGE(STATUS "Python > 3.7 - not linking to libpython")

Places

File 0001-Fix-build-with-Python-3.8-and-no-undefined-linker-flags.patch of Package libArcus (Revision 76d2f17cb845bc0e7029c7cc37649501)

Places