File efibootmgr-0.6.0-fail-visibly.diff of Package efibootmgr

Overview Repositories Revisions Requests Users Attributes Meta

File efibootmgr-0.6.0-fail-visibly.diff of Package efibootmgr (Revision 819c299c54b4f9786c80c104c8486adf)

Currently displaying revision 819c299c54b4f9786c80c104c8486adf , Show latest

From: Raymund Will <rw@suse.com>
Subject: Print EFI status on failed operations.
References: bnc#811767

Otherwise it's probably noticed only much too late.

V2: Produce failure output for '--create' as well.

Reported-by: Frederic Crozat <fcrozat@suse.com>
Signed-off-by: Raymund Will <rw@suse.com>
---
 src/efibootmgr/efibootmgr.c |    4 ++++
 1 file changed, 4 insertions(+)

--- a/src/efibootmgr/efibootmgr.c
+++ b/src/efibootmgr/efibootmgr.c
@@ -279,6 +279,7 @@ make_boot_var(list_t *boot_list)
 
 	status = create_variable(&boot->var_data);
 	if (status != EFI_SUCCESS) {
+		fprintf (stderr,"\n\nrequested operation failed: status=%lx\n\n", status);
 		free(boot);
 		return NULL;
 	}
@@ -1137,6 +1138,9 @@ main(int argc, char **argv)
 			}
 			show_boot_order();
 			show_boot_vars();
+		} else if (ret > 1) {
+			/* only print efi_status_t values as others already have a message! */
+			fprintf (stderr,"\n\nrequested operation failed: status=%lx\n\n", ret);
 		}
 	}
 	free_dirents(boot_names, num_boot_names);

Places

File efibootmgr-0.6.0-fail-visibly.diff of Package efibootmgr (Revision 819c299c54b4f9786c80c104c8486adf)

Places