File ipaddress-Make-sure-VF-min-max-rate-API-is-supp... of Package iproute2

Overview Repositories Revisions Requests Users Attributes Meta

File ipaddress-Make-sure-VF-min-max-rate-API-is-supported.patch of Package iproute2 (Revision 10b09744f30dc355771f1440b56f80da)

Currently displaying revision 10b09744f30dc355771f1440b56f80da , Show latest

From: Gal Pressman <galp@mellanox.com>
Date: Tue, 16 Jan 2018 15:41:59 +0200
Subject: ipaddress: Make sure VF min/max rate API is supported before using it
Patch-mainline: v4.15.0
Git-commit: 39315157ab16205846ed34996cf4c8c0f58113c0
References: bsc#1085669

When using the new minimum rate API and providing only one parameter
(minimum rate/maximum rate), we query the VF min and max rate regardless
of kernel support.
This resulted in segmentation fault in ipaddr_loop_each_vf, which tries
to access NULL pointer.

This patch identifies such cases by testing the VF table for NULL
pointer in IFLA_VF_RATE, and aborts the operation.
Aborting on the first VF is valid since if the kernel does not support
the new API for the first VF, it will not support it for the other VFs
as well.

Fixes: f89a2a05ffa9 ("Add support to configure SR-IOV VF minimum and maximum Tx rate through ip tool")
Cc: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: Gal Pressman <galp@mellanox.com>
Reviewed-by: Eran Ben Elisha <eranbe@mellanox.com>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Acked-by: Michal Kubecek <mkubecek@suse.cz>

---
 ip/ipaddress.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index 4900dce09df8..ed424b6fccfb 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -1777,6 +1777,12 @@ ipaddr_loop_each_vf(struct rtattr *tb[], int vfnum, int *min, int *max)
 
 	for (i = RTA_DATA(vflist); RTA_OK(i, rem); i = RTA_NEXT(i, rem)) {
 		parse_rtattr_nested(vf, IFLA_VF_MAX, i);
+
+		if (!vf[IFLA_VF_RATE]) {
+			fprintf(stderr, "VF min/max rate API not supported\n");
+			exit(1);
+		}
+
 		vf_rate = RTA_DATA(vf[IFLA_VF_RATE]);
 		if (vf_rate->vf == vfnum) {
 			*min = vf_rate->min_tx_rate;
-- 
2.16.2

Places

File ipaddress-Make-sure-VF-min-max-rate-API-is-supported.patch of Package iproute2 (Revision 10b09744f30dc355771f1440b56f80da)

Places