File bug-1158861_06-fix-segfault-for-invalid-charact... of Package lvm2

Overview Repositories Revisions Requests Users Attributes Meta

File bug-1158861_06-fix-segfault-for-invalid-characters-in-vg-name.patch of Package lvm2 (Revision 1360b48bb5534d1dad6452af9befd058)

Currently displaying revision 1360b48bb5534d1dad6452af9befd058 , Show latest

From 7cfbf3a394c2663fbeed17705320b83e69781720 Mon Sep 17 00:00:00 2001
From: David Teigland <teigland@redhat.com>
Date: Thu, 29 Aug 2019 11:35:46 -0500
Subject: [PATCH] fix segfault for invalid characters in vg name

Fixes a regression from commit ba7ff96faff0
"improve reading and repairing vg metadata"

where the error path for a vg name with invalid
charaters was missing an error flag, which led
to the caller not recognizing an error occured.
Previously, an error flag was hidden in the old
_vg_make_handle function.
---
 lib/metadata/metadata.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lib/metadata/metadata.c b/lib/metadata/metadata.c
index 2c61bdeca2..6d21ff99cc 100644
--- a/lib/metadata/metadata.c
+++ b/lib/metadata/metadata.c
@@ -4900,7 +4900,8 @@ struct volume_group *vg_read(struct cmd_context *cmd, const char *vg_name, const
 
 	if (!validate_name(vg_name)) {
 		log_error("Volume group name \"%s\" has invalid characters.", vg_name);
-		return NULL;
+		failure |= FAILED_NOTFOUND;
+		goto_bad;
 	}
 
 	/*
-- 
2.16.4

Places

File bug-1158861_06-fix-segfault-for-invalid-characters-in-vg-name.patch of Package lvm2 (Revision 1360b48bb5534d1dad6452af9befd058)

Places