File 0002-Multiply-instead-of-shifting.patch of Package libqt5-qtbase.17591

Overview Repositories Revisions Requests Users Attributes Meta

File 0002-Multiply-instead-of-shifting.patch of Package libqt5-qtbase.17591

From 24dea0df0a148e479235acef9e66b350cf504794 Mon Sep 17 00:00:00 2001
From: Robert Loehning <robert.loehning@qt.io>
Date: Wed, 8 Jul 2020 20:42:57 +0200
Subject: [PATCH 02/11] Multiply instead of shifting

The shift operator is undefined for negative values.

Fixes: oss-fuzz-23735
Change-Id: Ib4bad0bf2135f9ddc95f6d7de64d935a02b4791e
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit fd0c9fcaccbbb284f00c3403152bd3faf5940888)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit b7f2057ab1b3afd5a022dd56a819056ba230f7e9)
---
 src/gui/painting/qcosmeticstroker.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gui/painting/qcosmeticstroker.cpp b/src/gui/painting/qcosmeticstroker.cpp
index 436a62d486..12c9da6a28 100644
--- a/src/gui/painting/qcosmeticstroker.cpp
+++ b/src/gui/painting/qcosmeticstroker.cpp
@@ -473,7 +473,7 @@ void QCosmeticStroker::calculateLastPoint(qreal rx1, qreal ry1, qreal rx2, qreal
             qSwap(y1, y2);
         }
         int yinc = F16Dot16FixedDiv(y2 - y1, x2 - x1);
-        int y = y1 << 10;
+        int y = y1 * (1 << 10);
 
         int x = (x1 + 32) >> 6;
         int xs = (x2 + 32) >> 6;
-- 
2.25.1

Places

File 0002-Multiply-instead-of-shifting.patch of Package libqt5-qtbase.17591

Places