File log_full_stack_trace_of_unhandled_exceptions_as... of Package tuned.21660

Overview Repositories Revisions Requests Users Attributes Meta

File log_full_stack_trace_of_unhandled_exceptions_as_an_error.patch of Package tuned.21660

From: Ondřej Lysoněk <olysonek@redhat.com>
Subject: Log full stack trace of unhandled exceptions as an error
References: Bugfix found by git HEAD review
Patch-Mainline: v2.11.0-rc.1
Git-commit: 145b4551b4f4f94b2d04a10c0741ca67e86b3f40
Git-repo: https://github.com/openSUSE/tuned.git

Hiding the full stack trace in the debug output is not useful - it hides
information that would be useful for us when diagnosing a failure. It's
not always possible (and it's certainly an unnecessary burden for the
users) to later reproduce the issue with debug mode on. As a bonus, the
traceback will now stand out in the log, increasing the likelihood
that it will get noticed and reported.

Signed-off-by: Ondřej Lysoněk <olysonek@redhat.com>

Signed-off-by: Thomas Renninger <trenn@suse.com>

Index: tuned-2.10.0/tuned/units/manager.py
===================================================================
--- tuned-2.10.0.orig/tuned/units/manager.py	2019-01-08 15:07:03.000000000 +0100
+++ tuned-2.10.0/tuned/units/manager.py	2019-03-12 15:32:28.064845300 +0100
@@ -77,7 +77,7 @@ class Manager(object):
 			trace = traceback.format_exc()
 			log.error("BUG: Unhandled exception in %s: %s"
 					% (caller, str(e)))
-			log.debug(trace)
+			log.error(trace)
 			return exc_ret
 
 	def destroy_all(self):

Places

File log_full_stack_trace_of_unhandled_exceptions_as_an_error.patch of Package tuned.21660

Places