Sign Up
Log In
Log In
or
Sign Up
Places
All Projects
Status Monitor
Collapse sidebar
SUSE:SLE-15-SP2:Update
ndctl.9206
0001-ndctl-monitor-use-type-simple-instead-of-t...
Overview
Repositories
Revisions
Requests
Users
Attributes
Meta
File 0001-ndctl-monitor-use-type-simple-instead-of-type-forkin.patch of Package ndctl.9206
From cfdd874353e2798000dc1f9ebd99882c4d373c08 Mon Sep 17 00:00:00 2001 From: Johannes Thumshirn <jthumshirn@suse.de> Date: Mon, 7 Jan 2019 16:45:31 +0100 Subject: [PATCH] ndctl, monitor: use type=simple instead of type=forking Git-commit: 6efb0a555a21f9cb8b7219e30a819731bc28d27b Patch-mainline: v63.1 or v64 References: bsc#1120931 There is no need to use Type=forking for 'ndctl monitor', Type=simple is sufficient. When we use Type=forking and try to run ndctl monitor on a machine without pmem we even get the following error in the journal: Jan 07 13:34:54 bragi systemd[1]: Starting Ndctl Monitor Daemon... Jan 07 13:34:54 bragi ndctl[13776]: custom logging function 0x55ea57d60250 registered Jan 07 13:34:54 bragi systemd[1]: Started Ndctl Monitor Daemon. Jan 07 13:34:54 bragi ndctl[13777]: ndctl monitor daemon started Jan 07 13:34:54 bragi kill[13778]: kill: cannot find process "" Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Control process exited, code=exited status=1 Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Unit entered failed state. Jan 07 13:34:54 bragi systemd[1]: ndctl-monitor.service: Failed with result 'exit-code'. This is because the daemon exits and systemd is not able to determine $MAINPID anymore. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- ndctl/ndctl-monitor.service | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ndctl/ndctl-monitor.service b/ndctl/ndctl-monitor.service index 342a1b1972d5..eeedbd30bb42 100644 --- a/ndctl/ndctl-monitor.service +++ b/ndctl/ndctl-monitor.service @@ -2,9 +2,8 @@ Description=Ndctl Monitor Daemon [Service] -Type=forking -ExecStart=/usr/bin/ndctl monitor --daemon -ExecStop=/bin/kill ${MAINPID} +Type=simple +ExecStart=/usr/bin/ndctl monitor [Install] WantedBy=multi-user.target -- 2.16.4
Locations
Projects
Search
Status Monitor
Help
OpenBuildService.org
Documentation
API Documentation
Code of Conduct
Contact
Support
@OBShq
Terms
openSUSE Build Service is sponsored by
The Open Build Service is an
openSUSE project
.
Sign Up
Log In
Places
Places
All Projects
Status Monitor