File findif-multiple-routes-bnc892755.patch of Package resource-agents.2007

Overview Repositories Revisions Requests Users Attributes Meta

File findif-multiple-routes-bnc892755.patch of Package resource-agents.2007

commit b1d41edf4cab34f86facf7fc037a6a0783e79167
Author: Vincent Untz <vuntz@suse.com>
Date:   Wed Aug 20 16:17:33 2014 +0200

findif.sh: Use the most specific matching route
    
    When more than one interface is configured with a network that matches
    the IP address we're looking for, but with different networks, the "ip
    route" command we're using returns more than one line:
    
    ip -o -f inet route list match 10.122.24.59 scope link
    10.122.0.0/18 dev eth1.12  proto kernel  src 10.122.24.159
    10.122.24.0/25 dev eth0  proto kernel  src 10.122.24.53
    
    The code assumed that only one line would be returned, and so it's
    parsing only the first line, without trying to find out which line is
    the best match. What we want is the route with the bigger netmask. It
    turns out that it also means that it's the route with the bigger network
    IP.
    
    https://bugzilla.novell.com/show_bug.cgi?id=892755

diff --git a/heartbeat/findif.sh b/heartbeat/findif.sh
index fd92d9b..feb26ec 100644
--- a/heartbeat/findif.sh
+++ b/heartbeat/findif.sh
@@ -137,9 +137,9 @@ findif()
   fi
   if [ -n "$nic" ] ; then
     # NIC supports more than two.
-    set -- `ip -o -f $family route list match $match $scope | grep "dev $nic"`
+    set -- `ip -o -f $family route list match $match $scope | sort | tail -n1 | grep "dev $nic"`
   else
-    set -- `ip -o -f $family route list match $match $scope`
+    set -- `ip -o -f $family route list match $match $scope | sort | tail -n1`
   fi
   if [ $# = 0 ] ; then
     case $OCF_RESKEY_ip in

Places

File findif-multiple-routes-bnc892755.patch of Package resource-agents.2007

Places